[6.x] Fix malformed URLs with duplicate leading slashes resolving to home page#14982
Merged
jasonvarga merged 3 commits intoJul 13, 2026
Merged
Conversation
The following line already collapses any run of leading slashes to a single slash, making this addition a no-op.
Tests URL::makeRelative() directly instead of only through the DataRepository integration test.
Member
|
The Path::tidy() change was a no-op so I removed it, and there was already a more appropriate place for tests to live so I moved them. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLs with duplicate leading slashes (e.g.,
////url-does-not-exist) were incorrectly resolving to the home page instead of returning 404. This was caused byparse_url()interpreting strings like//unknownas protocol-relative URLs, causing the path to default to/.The fix normalizes duplicate leading slashes to a single slash before URL parsing in two places:
Path::tidy()- normalizes leading slashes in path stringsURL::makeRelative()- normalizes before parse_url() to prevent protocol-relative URL interpretationFixes #14980